Support external stacks and local function calls using local memory #460
Conversation
hawkinsw
commented
May 11, 2024
hawkinsw
commented
- Add support for invoking the interpreter and JIT'd code with an external stack. This feature is generally useful and will also make it easier to fuzz the runtime and check for correctness.
- Add support for local functions that use local memory. Prior to this commit, a local function could be called but could not use any local memory (without overwriting memory from another function).
hawkinsw
force-pushed
the
local_call_external_stack
branch
9 times, most recently
from
6e2a4d1
to
9a42663
Compare
hawkinsw
force-pushed
the
local_call_external_stack
branch
4 times, most recently
from
5bfcb6e
to
127a73e
Compare
hawkinsw
force-pushed
the
local_call_external_stack
branch
from
127a73e
to
00745b7
Compare
|
Can you please format the code using script/format-code? It looks like there are formatting changes that are unexpected. |
Of course!! I thought that I did. Sorry!! |
hawkinsw
force-pushed
the
local_call_external_stack
branch
2 times, most recently
from
9ccdf2e
to
b5a492e
Compare
I believe that I ran the formatter on the code (and did it correctly!). |
1. Add support for invoking the interpreter and JIT'd code with an external stack. This feature is generally useful and will also make it easier to fuzz the runtime and check for correctness. 2. Add support for local functions that use local memory. Prior to this commit, a local function could be called but could not use any local memory (without overwriting memory from another function). Signed-off-by: Will Hawkins <[email protected]>
hawkinsw
force-pushed
the
local_call_external_stack
branch
from
b5a492e
to
7208c4b
Compare
OK, it might just be possible the code wasn't formatted correctly to begin with. Which version of clang-format did you use? |
I will check!! I am constantly amazed how version-specific the formatter is! This problem occurs with another project I am working on, too. |
If you want, we can pick-up a newer version of the formatter if that helps. I think this is using the same one as eBPF-for-Windows, which is using a really old version (due to a dependency on an older version of Clang). If that is a route we want to pursue, I would suggest making the changes as a separate formatting only PR. |
hawkinsw
changed the title
