Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: configure cross compile test builds #39

Merged
merged 4 commits into from
Sep 15, 2019
Merged

build: configure cross compile test builds #39

merged 4 commits into from
Sep 15, 2019

Conversation

BondAnthony
Copy link
Contributor

This issue will setup goreleaser and cross compile kubectl-trace for multiple platforms. This would be a starting point for issue #9.

@BondAnthony
Copy link
Contributor Author

This would be just a starting point. Let me know if the direction looks good before I stop chopping up the existing make file and building images.

@fntlnz
Copy link
Member

fntlnz commented Jan 16, 2019 •
edited
Loading

The direction looks good @BondAnthony :) Thanks for your contribution

@fntlnz fntlnz self-requested a review January 21, 2019 18:48
@BondAnthony BondAnthony force-pushed the issue/cross-compile branch 2 times, most recently from 7b80297 to fc86302 Compare April 30, 2019 14:18
@BondAnthony BondAnthony force-pushed the issue/cross-compile branch 3 times, most recently from 025edd7 to 4c26845 Compare September 7, 2019 21:32
@fntlnz
Copy link
Member

fntlnz commented Sep 8, 2019

@BondAnthony do you need any help with this?

@BondAnthony
Copy link
Contributor Author

Interesting I wonder why dependencies are having an issue now. The changes from yesterday should allow for Travis to trigger a build when a semantic tag is created. Goreleaser will build, checksum and publish to github releases. However for this to work Travis needs the environment variable GITHUB_TOKEN set with the right permissions. This current implementation doesn’t include building Docker images.

Information on permissions can be found here. https://goreleaser.com/quick-start/

@fntlnz fntlnz mentioned this pull request Sep 15, 2019
Open
3 tasks
@fntlnz
Copy link
Member

fntlnz commented Sep 15, 2019

This is g2g! thanks @BondAnthony for the great work, I opened a follow up issue for further improvements here. #81

@fntlnz fntlnz changed the title Configure cross compile test builds build: configure cross compile test builds Sep 15, 2019
@fntlnz fntlnz merged commit 544f59d into iovisor:master Sep 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fntlnz fntlnz fntlnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BondAnthony @fntlnz