Skip to content

Avoid using deprecated string triple TargetRegistry overloads #5401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ekyooo merged 4 commits into from
Oct 14, 2025
+9 −4
Merged

Avoid using deprecated string triple TargetRegistry overloads #5401

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f3c8e1e
Avoid using deprecated string triple TargetRegistry overloads
boomanaiden154 Sep 28, 2025
0641e89
feedback
boomanaiden154 Sep 30, 2025
59b178b
feedback 2
boomanaiden154 Oct 12, 2025
812d449
feedback
boomanaiden154 Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/cc/bcc_debug.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,27 +120,32 @@ void SourceDebugger::dump() {
string TripleStr(mod_->getTargetTriple());
#endif
Triple TheTriple(TripleStr);
const Target *T = TargetRegistry::lookupTarget(TripleStr, Error);
#if LLVM_VERSION_MAJOR >= 22
const Triple &TripleArg = TheTriple;
#else
const string &TripleArg = TripleStr;
#endif
const Target *T = TargetRegistry::lookupTarget(TripleArg, Error);
if (!T) {
errs() << "Debug Error: cannot get target\n";
return;
}

std::unique_ptr<MCRegisterInfo> MRI(T->createMCRegInfo(TripleStr));
std::unique_ptr<MCRegisterInfo> MRI(T->createMCRegInfo(TripleArg));
if (!MRI) {
errs() << "Debug Error: cannot get register info\n";
return;
}

MCTargetOptions MCOptions;
std::unique_ptr<MCAsmInfo> MAI(T->createMCAsmInfo(*MRI, TripleStr, MCOptions));
std::unique_ptr<MCAsmInfo> MAI(T->createMCAsmInfo(*MRI, TripleArg, MCOptions));
if (!MAI) {
errs() << "Debug Error: cannot get assembly info\n";
return;
}

std::unique_ptr<MCSubtargetInfo> STI(
T->createMCSubtargetInfo(TripleStr, "", ""));
T->createMCSubtargetInfo(TripleArg, "", ""));
MCObjectFileInfo MOFI;
#if LLVM_VERSION_MAJOR >= 13
MCContext Ctx(TheTriple, MAI.get(), MRI.get(), STI.get(), nullptr);
Expand Down