Fix potential verification failure for opensnoop.py#5364
Merged
yonghong-song merged 1 commit intomasterfrom Jul 13, 2025
Merged
Fix potential verification failure for opensnoop.py#5364yonghong-song merged 1 commit intomasterfrom
yonghong-song merged 1 commit intomasterfrom
Conversation
When testing #5362, I found the following verification failure for fentry progs: ... 44: (b7) r0 = 0 ; R0_w=0 refs=3 45: (95) exit Unreleased reference id=3 alloc_insn=10 The reason is missing `ringbuf_discard` for certain conditionals for fentry progs since it used `ringbuf_reserve`. Adding `ringbuf_discard` in proper places can fix verification failure.
yonghong-song
requested review from
brendangregg,
davemarchevsky and
goldshtn
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When testing #5362, I found the following verification failure for fentry progs:
The reason is missing
ringbuf_discardfor certain conditionals for fentry progs since it usedringbuf_reserve. Addingringbuf_discardin proper places can fix verification failure.