limit commit root timestamp

iotexproject · Feb 3, 2024 · eb02d7a · eb02d7a
1 parent 3ee2334
commit eb02d7a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/contracts/VotingEscrow.sol b/contracts/VotingEscrow.sol
@@ -868,7 +868,7 @@ contract VotingEscrow is IVotingEscrow, ReentrancyGuardUpgradeable {
 
   /// @inheritdoc IVotingEscrow
   function commitNativeRoots(uint256 _timestamp, bytes32[] memory _pendingRoots) external {
-    if (_timestamp < nativeSnapshotTime) revert InvalidTimestamp();
+    if (_timestamp < nativeSnapshotTime || _timestamp > block.timestamp) revert InvalidTimestamp();
     if (msg.sender != team) revert NotTeam();
     for (uint256 i = 0; i < _pendingRoots.length; i++) {
       if (bytes32(0) == _pendingRoots[i]) revert InvalidRoot();

diff --git a/src/types/factories/contracts/VotingEscrow__factory.ts b/src/types/factories/contracts/VotingEscrow__factory.ts
diff --git a/test/VotingEscrow.test.ts b/test/VotingEscrow.test.ts
@@ -29,7 +29,7 @@ describe('VotingEscrow', function () {
     let node1: string;
     let node2: string;
 
-    before(function () {
+    before(async function () {
       now = Math.floor(new Date().getTime() / 1000);
 
       node1 = ethers.keccak256(
@@ -54,6 +54,7 @@ describe('VotingEscrow', function () {
     });
 
     it('create native ve', async function () {
+      await ethers.provider.send("evm_mine");
       await expect(ve.connect(accounts[1]).commitNativeRoots(now, [root])).to.be.revertedWithCustomError(ve, 'NotTeam');
       await ve.connect(accounts[0]).commitNativeRoots(now, [root]);
       await ve.connect(accounts[0]).approveNativeRoots();