Skip to content

fix(types,execution): Additional checks to multisig signature and package linkage #8046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 31, 2025
Merged

fix(types,execution): Additional checks to multisig signature and package linkage #8046

merged 2 commits into from
Jul 31, 2025

Conversation

@TheMrAI
Copy link
Contributor

@TheMrAI TheMrAI commented Jul 30, 2025 •
edited by lzpap
Loading

Description of change

Add additional signature and linkage checks.

Links to any relevant issues

fixes #8034

How the change has been tested

  • Basic tests (linting, compilation, formatting, unit/integration tests)
  • Patch-specific tests (correctness, functionality coverage)
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

Release Notes

  • Protocol: Adds a new protocol config options to enable additional signature and linkage checks.
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

@TheMrAI TheMrAI self-assigned this Jul 30, 2025
@vercel
Copy link

vercel bot commented Jul 30, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
apps-backend ⬜️ Ignored (Inspect) Visit Preview Jul 31, 2025 11:02am
apps-ui-kit ⬜️ Ignored (Inspect) Visit Preview Jul 31, 2025 11:02am
iota-evm-bridge ⬜️ Ignored (Inspect) Visit Preview Jul 31, 2025 11:02am
iota-multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Jul 31, 2025 11:02am
rebased-explorer ⬜️ Ignored (Inspect) Visit Preview Jul 31, 2025 11:02am
wallet-dashboard ⬜️ Ignored (Inspect) Visit Preview Jul 31, 2025 11:02am

@iota-ci iota-ci added sc-platform Issues related to the Smart Contract Platform group. vm-language Issues related to the VM & Language Team labels Jul 30, 2025
@TheMrAI TheMrAI force-pushed the vm-lang/upstream/8034-additional-package-signature-checks branch 6 times, most recently from 74c676f to b0e49b5 Compare July 30, 2025 15:25
miker83z
miker83z approved these changes Jul 30, 2025
View reviewed changes
TheMrAI
TheMrAI commented Jul 30, 2025
View reviewed changes
@TheMrAI TheMrAI mentioned this pull request Jul 30, 2025
Closed
@TheMrAI TheMrAI force-pushed the vm-lang/upstream/8034-additional-package-signature-checks branch 2 times, most recently from fb17aef to e668f25 Compare July 30, 2025 16:10
TheMrAI
TheMrAI commented Jul 30, 2025
View reviewed changes
@TheMrAI TheMrAI marked this pull request as ready for review July 30, 2025 17:50
@TheMrAI TheMrAI requested review from a team as code owners July 30, 2025 17:50
@TheMrAI TheMrAI force-pushed the vm-lang/upstream/8034-additional-package-signature-checks branch from e668f25 to c317af6 Compare July 30, 2025 18:01
@TheMrAI
fix(types,execution): Additional checks to multisig signature and pac…
d38220d 
…kages linkage

Add additional signature and linkage checks.
@TheMrAI TheMrAI force-pushed the vm-lang/upstream/8034-additional-package-signature-checks branch from c317af6 to d38220d Compare July 30, 2025 18:10
@DaughterOfMars DaughterOfMars mentioned this pull request Jul 31, 2025
Closed
@DaughterOfMars DaughterOfMars mentioned this pull request Jul 31, 2025
Merged
alexsporn
alexsporn reviewed Jul 31, 2025
View reviewed changes
@lzpap lzpap added this to the v1.4.x - protocol v10 milestone Jul 31, 2025
@TheMrAI
fix(iota-type): Handle InvalidLinkage error in sdk_types_conversion
db41104 
With the updated iota-sdk we now have access to InvalidLinkage.
@TheMrAI TheMrAI force-pushed the vm-lang/upstream/8034-additional-package-signature-checks branch from dc11ae6 to db41104 Compare July 31, 2025 11:00
@TheMrAI TheMrAI merged commit c02918a into develop Jul 31, 2025
39 checks passed
@TheMrAI TheMrAI deleted the vm-lang/upstream/8034-additional-package-signature-checks branch July 31, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@valeriyr valeriyr valeriyr approved these changes

@piotrm50 piotrm50 piotrm50 approved these changes

@alexsporn alexsporn alexsporn approved these changes

@kodemartin kodemartin kodemartin approved these changes

@miker83z miker83z miker83z approved these changes

@Thoralf-M Thoralf-M Thoralf-M approved these changes

@roman1e2f5p8s roman1e2f5p8s roman1e2f5p8s approved these changes

Assignees

@TheMrAI TheMrAI

Labels

sc-platform Issues related to the Smart Contract Platform group. vm-language Issues related to the VM & Language Team

Projects

None yet

Milestone

v1.4.x - protocol v10

Development

Successfully merging this pull request may close these issues.

[types,execution] Additional checks to multisig signature and packages linkage