fix(iota-framework): audit issue 58 extra mutable self in coin manager

crates/iota-framework-snapshot/manifest.json

@@ -38,5 +38,15 @@
       "0x000000000000000000000000000000000000000000000000000000000000000b",
       "0x000000000000000000000000000000000000000000000000000000000000107a"
     ]
+  },
+  "5": {
+    "git_revision": "7d485ce4ffab",
+    "package_ids": [
+      "0x0000000000000000000000000000000000000000000000000000000000000001",
+      "0x0000000000000000000000000000000000000000000000000000000000000002",
+      "0x0000000000000000000000000000000000000000000000000000000000000003",
+      "0x000000000000000000000000000000000000000000000000000000000000000b",
+      "0x000000000000000000000000000000000000000000000000000000000000107a"
+    ]
   }
 }

crates/iota-framework/packages/iota-framework/sources/coin_manager.move

@@ -214,7 +214,7 @@ module iota::coin_manager {
 
     // Retrieve the additional metadata
     public fun additional_metadata<T, Value: store>(
-        manager: &mut CoinManager<T>
+        manager: &CoinManager<T>
     ): &Value {
         assert!(df::exists_(&manager.id, b"additional_metadata"), EAdditionalMetadataDoesNotExist);
         let meta: &Value = df::borrow(&manager.id, b"additional_metadata");

crates/iota-swarm-config/tests/snapshots/snapshot_tests__populated_genesis_snapshot_matches-2.snap

@@ -1,15 +1,14 @@
 ---
 source: crates/iota-swarm-config/tests/snapshot_tests.rs
 expression: genesis.iota_system_object().into_genesis_version_for_tooling()
-snapshot_kind: text
 ---
 epoch: 0
 protocol_version: 5
 system_state_version: 1
 iota_treasury_cap:
   inner:
     id:
-      id: "0x3b7f70e166af7b4fb230a5144eeceea5991d570a699cc30adea9bf1b846ed17f"
+      id: "0x3b3fe49c7340d593842b22dc7ff655097282cb2bf3c202b3ae5384353ebe65d3"
     total_supply:
       value: "751500000000000000"
 validators:
@@ -245,56 +244,56 @@ validators:
         next_epoch_primary_address: ~
         extra_fields:
           id:
-            id: "0xbded405ff982bd33a2508412bb6f095e7d166a98f9766a187b66d1da151ef802"
+            id: "0xfed6410240402bed5c8073244179c34eac4279fb1a6408b82bd8ea04541c5552"
           size: 0
       voting_power: 10000
-      operation_cap_id: "0x6747c02f223ed93d4bec8f82c3851f95e228325321a3d4ac83e2ffc10946e355"
+      operation_cap_id: "0x861cc24a410bef8290708f1d5cf37c50a960bc6f234238dbd98d9f942bcdb907"
       gas_price: 1000
       staking_pool:
-        id: "0x3a5a7f9ddc55caf0a0b99f8a7524383ed0b70ea1bd202128920341317c4a5bba"
+        id: "0xac9459aae325a5a2d1dde825d48674824ef91b74709c2e2d2fccfaf5fbc71cb4"
         activation_epoch: 0
         deactivation_epoch: ~
         iota_balance: 1500000000000000
         rewards_pool:
           value: 0
         pool_token_balance: 1500000000000000
         exchange_rates:
-          id: "0x98191429aa6af224926b6e971822201d0faa4c3b6f4c5b08d4d516dcc6a2469e"
+          id: "0x484c6b097dea5bfdb04d7a0bcfdc75dd90685d306a2f5081a32df32f55bdb635"
           size: 1
         pending_stake: 0
         pending_total_iota_withdraw: 0
         pending_pool_token_withdraw: 0
         extra_fields:
           id:
-            id: "0x1636532ed60587386b2a0aa94395da3eed91382ebc7eb0881b5ab9f6a83d0272"
+            id: "0x6125c9213999631de0eee5f35230bc3e8457f58f7fd73a84f484428c6b7e6c82"
           size: 0
       commission_rate: 200
       next_epoch_stake: 1500000000000000
       next_epoch_gas_price: 1000
       next_epoch_commission_rate: 200
       extra_fields:
         id:
-          id: "0x1a15f7b105cc5bf01dc92e4692ff2657974c9f711cb19f0385aab4d535fad4dc"
+          id: "0xa2cd325317437018d9b793e7bb23dd63b9d882b707d5c1c11b62b31856bd352b"
         size: 0
   pending_active_validators:
     contents:
-      id: "0x79cb69475a34880fe09c61004a390a8b3534571694904a3b9461f8c484e121aa"
+      id: "0x23b810e7d6a390ba3f20ce82a5c5ad792350afbf4f8d4ce4c4da1c0d3d9e799f"
       size: 0
   pending_removals: []
   staking_pool_mappings:
-    id: "0x2f8586afa84a5e6fc2f1a06052675b2734a4fd2bbdb5c67ab775bdd0007416ad"
+    id: "0x294f88ce9121573f087785ad00bf382a683cd5cf86c34999e1acf0de7f398ae2"
     size: 1
   inactive_validators:
-    id: "0x37a84bd0417c61d190d6d22026e90de5f684599eacff033d41c3abf4deeae505"
+    id: "0x14a5884e2a3cfa2072da2cd6c93613f180434db4473f55c779d7e20d2cc3db67"
     size: 0
   validator_candidates:
-    id: "0x23491bf78fc84411a64552c41d3c5aa1bc067a7513f22b4fabf9bfbe245bceeb"
+    id: "0x065cb8b2a5277db0366a006e241fca9f13ec3de5a86957909bdb99a14c7e7b8f"
     size: 0
   at_risk_validators:
     contents: []
   extra_fields:
     id:
-      id: "0xe3dfe55a068b38b8dccb16b8daa43b0de096ecbbb1ccc342b8be8471c68260b2"
+      id: "0x94e4197065af537518036a92aea9c63faf69eca79e672414526fd1cff990e5a2"
     size: 0
 storage_fund:
   total_object_storage_rebates:
@@ -311,7 +310,7 @@ parameters:
   validator_low_stake_grace_period: 7
   extra_fields:
     id:
-      id: "0xb4275a605f57fe579662168b4c33c4c8aeeca4dba6e4e10d5c276af060132b50"
+      id: "0x65b331f7456bc540160656fc8b0f69fd092461a2d2a62b36f6803946d326a54c"
     size: 0
 iota_system_admin_cap:
   dummy_field: false
@@ -328,5 +327,5 @@ safe_mode_non_refundable_storage_fee: 0
 epoch_start_timestamp_ms: 10
 extra_fields:
   id:
-    id: "0x158eeff816c6728c95efb2ce658008d5c5cad0b4a88a1f1d3ddaa93af91162c0"
+    id: "0x62afa9e1c8acfd6f75e1f8f4b2972e886a80453256e856990252cff3d020261e"
   size: 0