[types] Gas logic tweaks and cleanups · MystenLabs/sui@9e729bf

[miker83z]

Warning

to check the effects on our codebase and if we need it

• type: feat
• side effects: medium (requires upgrade)

MystenLabs/sui@9e729bf

[valeriyr]

A new gas model version of charging native functions is implemented here. What was changed:

1. Added a new protocol config flag native_charging_v2 and updated the parameters related to the native gas cost; a new gas model version 9 was created as well:

cfg.poseidon_bn254_cost_per_block = Some(388);

cfg.gas_model_version = Some(9);
cfg.feature_flags.native_charging_v2 = true;
cfg.bls12381_bls12381_min_sig_verify_cost_base = Some(44064);
cfg.bls12381_bls12381_min_pk_verify_cost_base = Some(49282);
cfg.ecdsa_k1_secp256k1_verify_keccak256_cost_base = Some(1470);
cfg.ecdsa_k1_secp256k1_verify_sha256_cost_base = Some(1470);
cfg.ecdsa_r1_secp256r1_verify_sha256_cost_base = Some(4225);
cfg.ecdsa_r1_secp256r1_verify_keccak256_cost_base = Some(4225);
cfg.ecvrf_ecvrf_verify_cost_base = Some(4848);
cfg.ed25519_ed25519_verify_cost_base = Some(1802);

// Manually changed to be "under cost"
cfg.ecdsa_r1_ecrecover_keccak256_cost_base = Some(1173);
cfg.ecdsa_r1_ecrecover_sha256_cost_base = Some(1173);
cfg.ecdsa_k1_ecrecover_keccak256_cost_base = Some(500);
cfg.ecdsa_k1_ecrecover_sha256_cost_base = Some(500);

cfg.groth16_prepare_verifying_key_bls12381_cost_base = Some(53838);
cfg.groth16_prepare_verifying_key_bn254_cost_base = Some(82010);
cfg.groth16_verify_groth16_proof_internal_bls12381_cost_base = Some(72090);
cfg.groth16_verify_groth16_proof_internal_bls12381_cost_per_public_input =
    Some(8213);
cfg.groth16_verify_groth16_proof_internal_bn254_cost_base = Some(115502);
cfg.groth16_verify_groth16_proof_internal_bn254_cost_per_public_input =
    Some(9484);

cfg.hash_keccak256_cost_base = Some(10);
cfg.hash_blake2b256_cost_base = Some(10);

// group ops
cfg.group_ops_bls12381_decode_scalar_cost = Some(7);
cfg.group_ops_bls12381_decode_g1_cost = Some(2848);
cfg.group_ops_bls12381_decode_g2_cost = Some(3770);
cfg.group_ops_bls12381_decode_gt_cost = Some(3068);

cfg.group_ops_bls12381_scalar_add_cost = Some(10);
cfg.group_ops_bls12381_g1_add_cost = Some(1556);
cfg.group_ops_bls12381_g2_add_cost = Some(3048);
cfg.group_ops_bls12381_gt_add_cost = Some(188);

cfg.group_ops_bls12381_scalar_sub_cost = Some(10);
cfg.group_ops_bls12381_g1_sub_cost = Some(1550);
cfg.group_ops_bls12381_g2_sub_cost = Some(3019);
cfg.group_ops_bls12381_gt_sub_cost = Some(497);

cfg.group_ops_bls12381_scalar_mul_cost = Some(11);
cfg.group_ops_bls12381_g1_mul_cost = Some(4842);
cfg.group_ops_bls12381_g2_mul_cost = Some(9108);
cfg.group_ops_bls12381_gt_mul_cost = Some(27490);

cfg.group_ops_bls12381_scalar_div_cost = Some(91);
cfg.group_ops_bls12381_g1_div_cost = Some(5091);
cfg.group_ops_bls12381_g2_div_cost = Some(9206);
cfg.group_ops_bls12381_gt_div_cost = Some(27804);

cfg.group_ops_bls12381_g1_hash_to_base_cost = Some(2962);
cfg.group_ops_bls12381_g2_hash_to_base_cost = Some(8688);

cfg.group_ops_bls12381_g1_msm_base_cost = Some(62648);
cfg.group_ops_bls12381_g2_msm_base_cost = Some(131192);
cfg.group_ops_bls12381_g1_msm_base_cost_per_input = Some(1333);
cfg.group_ops_bls12381_g2_msm_base_cost_per_input = Some(3216);

cfg.group_ops_bls12381_uncompressed_g1_to_g1_cost = Some(677);
cfg.group_ops_bls12381_g1_to_uncompressed_g1_cost = Some(2099);
cfg.group_ops_bls12381_uncompressed_g1_sum_base_cost = Some(77);
cfg.group_ops_bls12381_uncompressed_g1_sum_cost_per_term = Some(26);

cfg.group_ops_bls12381_pairing_cost = Some(26897);
cfg.group_ops_bls12381_uncompressed_g1_sum_max_terms = Some(1200);

cfg.validator_validate_metadata_cost_base = Some(20000);

2. A threshold was added after which native functions contribute to the virtual instruction count:

// Threshold after which native functions contribute to virtual instruction count.
const V2_NATIVE_FUNCTION_CALL_THRESHOLD: u64 = 700;

It means that we count native function charges and if the amount exceeds 700:

// Charge for the stack operations. We don't count this as an "instruction" since we
// already accounted for the `Call` instruction in the
// `charge_native_function_before_execution` call.

// The amount returned by the native function is viewed as the "virtual" instruction cost
// for the native function, and will be charged and contribute to the overall cost tier of
// the transaction accordingly.
self.charge(amount.into(), pushes, 0, size_increase.into(), 0)

if it doesn't exceed:

// Charge for the stack operations. We don't count this as an "instruction" since we
// already accounted for the `Call` instruction in the
// `charge_native_function_before_execution` call.
self.charge(0, pushes, 0, size_increase.into(), 0)?;
// Now charge the gas that the native function told us to charge.
self.deduct_gas(amount)

3. Changed the logic of some native Move functions where the price is calculated.