feat(ffi): add MoveModule, MoveFunction and their inner types as records #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibault-martinez
approved these changes
Aug 12, 2025
DaughterOfMars
approved these changes
Aug 12, 2025
thibault-martinez
approved these changes
Aug 12, 2025
Member
|
Conflicts |
Closed
| #[derive(Debug, derive_more::From, uniffi::Object)] | ||
| pub struct MoveFunction(pub iota_graphql_client::query_types::MoveFunction); | ||
| #[uniffi::remote(Record)] | ||
| pub struct MoveFunction { |
Contributor
There was a problem hiding this comment.
Maybe we could just append Query to all of the queries for consistency? We should probably do this in the core crate too eventually.
Member
Author
There was a problem hiding this comment.
Seems like there is no way to use uniffi::remote(Record) with a different name than in the core crate, so would require this change in the core crate
Don't want to do more changes than needed now, but I agree that this is something to consider
DaughterOfMars
approved these changes
Aug 13, 2025
Closed
howjmay
pushed a commit
to howjmay/iota-rust-sdk
that referenced
this pull request
Oct 7, 2025
This was referenced Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59
Had to rename graphql MoveStruct to MoveStructQuery, because it was conflicting with the other one in iota-sdk-types:
error: symbolUNIFFI_META_IOTA_SDK_FFI_RECORD_MOVESTRUCTis already defined