Skip to content

Conversation

@DaughterOfMars
Copy link
Contributor

Description

The amount param for send_iota was optional, but this meant that not providing it would send the entire gas coin, which is probably undesirable. This PR makes it required.

Copy link
Member

@thibault-martinez thibault-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't say it was undesirable nor dangerous, seems pretty expected to me that no amount means the whole thing. But I'm fine changing it anyway.

@DaughterOfMars
Copy link
Contributor Author

I wouldn't say it was undesirable nor dangerous, seems pretty expected to me that no amount means the whole thing. But I'm fine changing it anyway.

I agree with this in the case of send_coins where you specify the coins you want to send. But here the gas may be chosen for you and I think, even though it should be obvious that providing no amount would have SOME effect, it's not clear in this case what effect that would be.

@DaughterOfMars DaughterOfMars merged commit 70b38b7 into sdk-bindings Oct 23, 2025
14 checks passed
@DaughterOfMars DaughterOfMars deleted the fix/send-iota-opt branch October 23, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants