feat(tx-builder): improve TransactionBuilder::make_move_vec() docs
#336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex6323
changed the title
TransactionBuilder::make_move_vec()TransactionBuilder::make_move_vec() docs
Contributor
There was a problem hiding this comment.
This example isn't about make_move_vec and tbh it's a worse way to use the builder so I say revert this
Contributor
Author
There was a problem hiding this comment.
okay, do you think we should have a separate example about .make_move_vec then?
| }) | ||
| } | ||
|
|
||
| /// Make a move vector from a list of elements. |
Contributor
There was a problem hiding this comment.
Maybe we should also mention something like:
/// Often it is possible (and more efficient) to pass a rust slice or `Vec` instead of calling this function, which will serialize the bytes into a move vector pure argument.
Contributor
Author
There was a problem hiding this comment.
yeah, makes sense to add this comment, Can you come up with a valid use-case? Then I'ld add another example just for that, because currently .make_move_vec is not covered I think.
Contributor
There was a problem hiding this comment.
I don't know of a valid use-case other than if there's something we can't do with the normal syntax that I'm not thinking of
This was referenced Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #296