-
Notifications
You must be signed in to change notification settings - Fork 3
feat(ffi): Add bcs conversion for primitive types + String
#332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
DaughterOfMars
merged 10 commits into
sdk-bindings
from
feat/expose-bcs-conversion-part2
Oct 23, 2025
Merged
feat(ffi): Add bcs conversion for primitive types + String
#332
DaughterOfMars
merged 10 commits into
sdk-bindings
from
feat/expose-bcs-conversion-part2
Oct 23, 2025
+1,703
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
How does this close #231? |
Contributor
DaughterOfMars
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this isn't doing anything. The issue is about adding to_bcs and from_bcs for every type we want to serialize
Co-authored-by: DaughterOfMars <[email protected]>
String
thibault-martinez
approved these changes
Oct 23, 2025
This was referenced Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #231