feat(transaction-builder): Make client in builder extensible and passable by ref #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thoralf-M
reviewed
Oct 15, 2025
Thoralf-M
reviewed
Oct 15, 2025
Thoralf-M
approved these changes
Oct 16, 2025
Thoralf-M
approved these changes
Nov 6, 2025
This was referenced Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
ClientMethodstrait, which makes it possible to implement new clients that can be used by the transaction builder. Additionally, these can now be passed in as a reference to the builder.NOTE: In order to make this not depend on the graphql typess, specifically those for the
DryRunResult, I moved them into the types crate next to theTransactionEffects.