chore(cleanup): use better names for default address constants #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DaughterOfMars
left a comment
DaughterOfMars
left a comment
There was a problem hiding this comment.
Very much agree with this change. While you're at it, can you add these to the FFI?
Alex6323
force-pushed
the
chore/semantic-naming-for-default-addresses
branch
from
f9a830e to
9cdbcb2
Compare
Thoralf-M
reviewed
Oct 14, 2025
Thoralf-M
reviewed
Oct 14, 2025
Co-authored-by: DaughterOfMars <[email protected]>
Co-authored-by: DaughterOfMars <[email protected]>
Thoralf-M
approved these changes
Oct 14, 2025
DaughterOfMars
approved these changes
Oct 14, 2025
This was referenced Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Never liked the ONE, TWO, THREE cryptic constants. Instead I propose to give proper names as to what they represent. Makes the code more readable I think.