Skip to content

feat: Return ObjectChange in ExecuteTx and DryRun #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: sdk-bindings
Choose a base branch
from
Open

feat: Return ObjectChange in ExecuteTx and DryRun #278

wants to merge 1 commit into from

Conversation

howjmay
Copy link
Member

@howjmay howjmay commented Oct 10, 2025 •
edited
Loading

In the previous JSON RPC, iota_executeTransactionBlock and dry run would return
object changes and balance changes. However, thee fields are not returned in
the current GraphQL sdk.

@howjmay howjmay marked this pull request as draft October 10, 2025 08:21
@howjmay howjmay force-pushed the modify-sdk branch 5 times, most recently from 72fc959 to fc45052 Compare October 10, 2025 17:17
@howjmay howjmay marked this pull request as ready for review October 11, 2025 17:30
Thoralf-M
Thoralf-M reviewed Oct 14, 2025
View reviewed changes
@howjmay howjmay force-pushed the modify-sdk branch 3 times, most recently from 1da8677 to 8780be8 Compare October 15, 2025 08:34
@howjmay
feat: Return ObjectChange in ExecuteTx and DryRun
d17c441 
In the previous JSON RPC, iota_executeTransactionBlock and dry run would return
object changes and balance changes. However, thee fields are not returned in
the current GraphQL sdk.
@howjmay
Copy link
Member Author

howjmay commented Oct 15, 2025

Hi @Thoralf-M I am meeting a problem, and I am having no idea how to solve it.
This PR aims to return ObjectChanges. However, the object type of a created object in the ObjectChanges is not returned.
I am not sure whether it is an issue in GraphQL side? Maybe it is just not possible based on the current GraphQL, or node impl?
Thank you

@Thoralf-M
Copy link
Member

Hi @Thoralf-M I am meeting a problem, and I am having no idea how to solve it. This PR aims to return ObjectChanges. However, the object type of a created object in the ObjectChanges is not returned. I am not sure whether it is an issue in GraphQL side? Maybe it is just not possible based on the current GraphQL, or node impl? Thank you

GraphQL definitely supports that, seems like the SDK should be adjusted so TransactionEffectsV1::changed_objects contain the full objects for the input and output changes instead of the current ObjectIn, ObjectOut structs

@Thoralf-M Thoralf-M mentioned this pull request Oct 15, 2025
Open
@Thoralf-M
Copy link
Member

I created this issue #314 to make the data available

@howjmay
Copy link
Member Author

howjmay commented Oct 15, 2025

Thank you @Thoralf-M

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Thoralf-M Thoralf-M Thoralf-M left review comments

@DaughterOfMars DaughterOfMars Awaiting requested review from DaughterOfMars

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@howjmay @Thoralf-M