fix(transaction-builder, examples): Fix gas budget calculation

bindings/go/examples/generic_move_function/main.go

@@ -37,7 +37,7 @@ func main() {
 		nil,
 	)
 
-	builder.Gas(gas_coin_id).GasBudget(1000000000)
+	builder.Gas(gas_coin_id)
 
 	res, err := builder.DryRun(false)
 	if err.(*sdk.SdkFfiError) != nil {

bindings/go/examples/prepare_send_iota/main.go

@@ -22,7 +22,7 @@ func main() {
 
 	builder := sdk.TransactionBuilderInit(fromAddress, client)
 	builder.TransferObjects(toAddress, []*sdk.PtbArgument{sdk.PtbArgumentObjectId(coinObjId)})
-	builder.Gas(gasCoinObjId).GasBudget(1000000000)
+	builder.Gas(gasCoinObjId)
 
 	txn, err := builder.Finish()
 	if err.(*sdk.SdkFfiError) != nil {

bindings/go/examples/prepare_send_iota_multi/main.go

@@ -43,7 +43,7 @@ func main() {
 		builder.TransferObjects(recipient, []*sdk.PtbArgument{sdk.PtbArgumentRes(labels[idx])})
 	}
 
-	builder.Gas(gasCoinId).GasBudget(1000000000)
+	builder.Gas(gasCoinId)
 
 	txn, err := builder.Finish()
 	if err.(*sdk.SdkFfiError) != nil {

bindings/go/examples/stake/main.go

@@ -58,7 +58,7 @@ func main() {
 		nil,
 		nil,
 	)
-	builder.Gas(gasCoinObjId).GasBudget(1000000000)
+	builder.Gas(gasCoinObjId)
 
 	res, err := builder.DryRun(false)
 	if err.(*sdk.SdkFfiError) != nil {

bindings/go/examples/unstake/main.go

@@ -50,7 +50,7 @@ func main() {
 		nil,
 	)
 
-	builder.Gas(gasCoin.ObjectId()).GasBudget(1000000000)
+	builder.Gas(gasCoin.ObjectId())
 
 	res, err := builder.DryRun(false)
 	if err.(*sdk.SdkFfiError) != nil {

bindings/kotlin/examples/GenericMoveFunction.kt

@@ -62,7 +62,7 @@ fun main() = runBlocking {
                 )
         )
 
-        builder.gas(gasCoinId).gasBudget(1000000000uL)
+        builder.gas(gasCoinId)
 
         val res = builder.dryRun()
 

bindings/kotlin/examples/PrepareSendIota.kt

@@ -35,7 +35,7 @@ fun main() = runBlocking {
                 listOf(PtbArgument.objectId(coinId)),
         )
 
-        builder.gas(gasCoinId).gasBudget(1000000000uL)
+        builder.gas(gasCoinId)
 
         val txn = builder.finish()
 

bindings/kotlin/examples/PrepareSendIotaMulti.kt

@@ -53,7 +53,7 @@ fun main() = runBlocking {
         for ((i, r) in recipients.withIndex()) {
             builder.transferObjects(Address.fromHex(r.first), listOf(PtbArgument.res(labels[i])))
         }
-        builder.gas(gasCoinId).gasBudget(1000000000uL)
+        builder.gas(gasCoinId)
 
         val txn = builder.finish()
 

bindings/kotlin/examples/Stake.kt

@@ -48,7 +48,7 @@ fun main() = runBlocking {
                         PtbArgument.address(validator.address)
                 ),
         )
-        builder.gas(gasCoinId).gasBudget(1000000000uL)
+        builder.gas(gasCoinId)
 
         val res = builder.dryRun()
 

bindings/kotlin/examples/Unstake.kt

@@ -44,7 +44,7 @@ fun main() = runBlocking {
                         PtbArgument.objectId(stakedIota.objectId())
                 ),
         )
-        builder.gas(gasCoin.objectId()).gasBudget(1000000000uL)
+        builder.gas(gasCoin.objectId())
 
         val res = builder.dryRun()
 

bindings/python/examples/generic_move_function.py

@@ -51,7 +51,7 @@ async def main():
         [TypeTag.new_address(), TypeTag.new_u64()],
     )
 
-    builder.gas(gas_coin_id).gas_budget(1000000000)
+    builder.gas(gas_coin_id)
 
     res = await builder.dry_run()
 

bindings/python/examples/prepare_send_iota.py

@@ -31,7 +31,7 @@ async def main():
             to_address,
             [PtbArgument.object_id(coin_id)],
         )
-        builder.gas(gas_coin_id).gas_budget(1000000000)
+        builder.gas(gas_coin_id)
 
         txn = await builder.finish()
 

bindings/python/examples/prepare_send_iota_multi.py

@@ -34,7 +34,7 @@ async def main():
     builder.split_coins(gas_coin_id, amounts, labels)
     for i, r in enumerate(recipients):
         builder.transfer_objects(Address.from_hex(r[0]), [PtbArgument.res(labels[i])])
-    builder.gas(gas_coin_id).gas_budget(1000000000)
+    builder.gas(gas_coin_id)
 
     txn = await builder.finish()
 

bindings/python/examples/stake.py

@@ -41,7 +41,7 @@ async def main():
                 PtbArgument.address(validator.address),
             ],
         )
-        builder.gas(gas_coin_id).gas_budget(1000000000)
+        builder.gas(gas_coin_id)
 
         res = await builder.dry_run()
         if res.error is not None:

bindings/python/examples/unstake.py

@@ -38,7 +38,7 @@ async def main():
                 PtbArgument.object_id(staked_iota.object_id()),
             ],
         )
-        builder.gas(gas_coin.object_id()).gas_budget(1000000000)
+        builder.gas(gas_coin.object_id())
 
         res = await builder.dry_run()
         if res.error is not None:

crates/iota-graphql-client/examples/generic_move_function.rs

@@ -25,8 +25,7 @@ async fn main() -> Result<()> {
         .move_call(Address::TWO, "vec_map", "from_keys_values")
         .generics::<(Address, u64)>()
         .arguments((vec![address1, address2], vec![10000000u64, 20000000u64]))
-        .gas("0xa1d009e8dafe20b1cba05e08aea488aafae1f89d892c3eaef6c0994e155e441a".parse()?)
-        .gas_budget(1000000000);
+        .gas("0xa1d009e8dafe20b1cba05e08aea488aafae1f89d892c3eaef6c0994e155e441a".parse()?);
 
     let res = builder.dry_run(false).await?;
 

crates/iota-graphql-client/examples/prepare_send_iota.rs

@@ -29,8 +29,7 @@ async fn main() -> Result<()> {
         )
         .gas(ObjectId::from_str(
             "0x0b0270ee9d27da0db09651e5f7338dfa32c7ee6441ccefa1f6e305735bcfc7ab",
-        )?)
-        .gas_budget(1000000000);
+        )?);
 
     let txn = builder.finish().await?;
 

crates/iota-graphql-client/examples/prepare_send_iota_multi.rs

@@ -45,7 +45,7 @@ async fn main() -> Result<()> {
         builder.transfer_objects(Address::from_str(address)?, res(&labels[i]));
     }
 
-    builder.gas(gas_coin).gas_budget(1000000000);
+    builder.gas(gas_coin);
 
     let txn = builder.finish().await?;
 

crates/iota-graphql-client/examples/stake.rs

@@ -41,8 +41,7 @@ async fn main() -> Result<()> {
         ))
         .gas(ObjectId::from_str(
             "0x0b0270ee9d27da0db09651e5f7338dfa32c7ee6441ccefa1f6e305735bcfc7ab",
-        )?)
-        .gas_budget(1000000000);
+        )?);
 
     let res = builder.dry_run(false).await?;
 

crates/iota-graphql-client/examples/unstake.rs

@@ -50,8 +50,7 @@ async fn main() -> Result<()> {
             SharedMut(ObjectId::from_str("0x5")?),
             staked_iota.object_id(),
         ))
-        .gas(gas_coin.object_id())
-        .gas_budget(1000000000);
+        .gas(gas_coin.object_id());
 
     let res = builder.dry_run(false).await?;
 

crates/iota-transaction-builder/src/builder/mod.rs

@@ -813,9 +813,12 @@ impl<L> TransactionBuilder<Client, L> {
         if self.data.gas_budget.is_none() {
             let res = self
                 .client
-                .dry_run_tx(&txn, true)
+                .dry_run_tx_kind(&txn.kind, true, Default::default())
                 .await
                 .map_err(Error::Client)?;
+            if let Some(err) = res.error {
+                return Err(Error::DryRun(err));
+            }
             txn.gas_payment.budget = res
                 .effects
                 .ok_or_else(|| Error::MissingGasBudget)?

crates/iota-transaction-builder/src/error.rs

@@ -45,4 +45,6 @@ pub enum Error {
     Signature(iota_crypto::SignatureError),
     #[error(transparent)]
     Client(iota_graphql_client::error::Error),
+    #[error("Failed to dry run transaction: {0}")]
+    DryRun(String),
 }

crates/iota-transaction-builder/src/lib.rs

@@ -151,7 +151,6 @@ mod tests {
                 .unwrap(),
         ));
         tx.gas_price(1000);
-        tx.gas_budget(500000000);
 
         tx.finish().unwrap();
     }