feat(iota-sdk-ffi): add secp256r1 crypto types #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

thibault-martinez merged 18 commits into sdk-bindings from ffi/secp256r1

Aug 21, 2025

Member

Thoralf-M commented Aug 19, 2025

Fixes #121

DaughterOfMars reviewed

View reviewed changes

crates/iota-sdk-ffi/src/types/crypto/secp256r1.rs Outdated Show resolved Hide resolved

Thoralf-M force-pushed the ffi/secp256r1 branch from 927cf84 to f6d8fd2 Compare

August 19, 2025 12:18

Member Author

Thoralf-M commented Aug 19, 2025

Will rebase after #125 is merged

Thoralf-M linked an issue

that may be closed by this pull request

FFI for the Secp256r1PrivateKey, Secp256r1VerifyingKey and Secp256r1Verifier types #121

Closed

Thoralf-M closed this

Thoralf-M force-pushed the ffi/secp256r1 branch from f6d8fd2 to 30fcfd0 Compare

August 19, 2025 13:05


          feat(iota-sdk-ffi): add secp256r1 crypto types

d0c0849

Thoralf-M reopened this

thibault-martinez reviewed

View reviewed changes

crates/iota-sdk-ffi/src/crypto/secp256r1.rs Outdated Show resolved Hide resolved


          Update crates/iota-sdk-ffi/src/crypto/secp256r1.rs

e71d269

Co-authored-by: Thibault Martinez <[email protected]>

DaughterOfMars reviewed

View reviewed changes

crates/iota-sdk-ffi/src/crypto/secp256r1.rs Outdated Show resolved Hide resolved

thibault-martinez reviewed

View reviewed changes

crates/iota-sdk-ffi/src/crypto/secp256r1.rs Show resolved Hide resolved

thibault-martinez reviewed

View reviewed changes

crates/iota-sdk-ffi/src/crypto/secp256r1.rs Show resolved Hide resolved

thibault-martinez reviewed

View reviewed changes

crates/iota-sdk-ffi/src/crypto/secp256r1.rs Outdated Show resolved Hide resolved

thibault-martinez reviewed

View reviewed changes

crates/iota-sdk-ffi/src/crypto/secp256r1.rs Outdated Show resolved Hide resolved

Thoralf-M and others added 2 commits

August 19, 2025 15:42


          Update crates/iota-sdk-ffi/src/crypto/secp256r1.rs

Co-authored-by: DaughterOfMars <[email protected]>


          add missing methods

1801fa4

DaughterOfMars reviewed

View reviewed changes

crates/iota-sdk-ffi/src/crypto/secp256r1.rs Outdated Show resolved Hide resolved

thibault-martinez reviewed

View reviewed changes

crates/iota-sdk-ffi/src/crypto/secp256r1.rs Outdated Show resolved Hide resolved

Thoralf-M added 3 commits

August 20, 2025 09:33


          address review comments

407bc67


          result for constructor

029fa56


          Return result instead of bool for failure reasons

23d8dd6

thibault-martinez reviewed

View reviewed changes

crates/iota-sdk-ffi/src/crypto/secp256r1.rs Outdated Show resolved Hide resolved

thibault-martinez reviewed

View reviewed changes

crates/iota-sdk-ffi/src/crypto/secp256r1.rs Outdated Show resolved Hide resolved


          update imports

dba0d76

DaughterOfMars reviewed

View reviewed changes

crates/iota-sdk-ffi/src/crypto/secp256r1.rs Outdated Show resolved Hide resolved

Thoralf-M and others added 3 commits

August 20, 2025 10:51


          Update crates/iota-sdk-ffi/src/crypto/secp256r1.rs

a29d10e

Co-authored-by: DaughterOfMars <[email protected]>


          use Ok() + .into() instead of map_err()

3ee054e


          clippy

fa98d77

DaughterOfMars reviewed

View reviewed changes

crates/iota-sdk-ffi/src/crypto/secp256r1.rs Outdated Show resolved Hide resolved


          Update crates/iota-sdk-ffi/src/crypto/secp256r1.rs

714bd80

Co-authored-by: DaughterOfMars <[email protected]>

DaughterOfMars approved these changes

View reviewed changes

Contributor

DaughterOfMars left a comment

I still think we should use imports to shorten up the long type signatures but 🤷‍♀️

Member Author

Thoralf-M commented Aug 20, 2025

I still think we should use imports to shorten up the long type signatures but 🤷‍♀️

How would you name the aliases? All with some prefix?

Member

thibault-martinez commented Aug 20, 2025

I still think we should use imports to shorten up the long type signatures but 🤷‍♀️

How would you name the aliases? All with some prefix?

I don't think she meant having aliases

Contributor

DaughterOfMars commented Aug 20, 2025

I still think we should use imports to shorten up the long type signatures but 🤷‍♀️

How would you name the aliases? All with some prefix?

I don't think she meant having aliases

Yeah, I just meant importing the inner types inside the fns


          import inner types

444dd9b

Member Author

Thoralf-M commented Aug 20, 2025

@DaughterOfMars did you want it like this? Not sure if I prefer that

DaughterOfMars reviewed

View reviewed changes

crates/iota-sdk-ffi/src/crypto/secp256r1.rs Outdated Show resolved Hide resolved

Thoralf-M added 2 commits

August 21, 2025 09:35


          Revert "import inner types"

4aebca1

This reverts commit 444dd9b.


          simplify

5791a56

DaughterOfMars approved these changes

View reviewed changes

thibault-martinez reviewed

View reviewed changes

crates/iota-sdk-ffi/src/crypto/secp256r1.rs Outdated Show resolved Hide resolved

thibault-martinez reviewed

View reviewed changes

crates/iota-sdk-ffi/src/crypto/secp256r1.rs Outdated Show resolved Hide resolved


          add missing verify methods, return result

bf7d39b

thibault-martinez approved these changes

View reviewed changes

DaughterOfMars reviewed

View reviewed changes

crates/iota-sdk-ffi/src/crypto/secp256r1.rs Show resolved Hide resolved

Member

thibault-martinez commented Aug 21, 2025

conflicts

Thoralf-M added 2 commits

August 21, 2025 14:22


          Merge branch 'sdk-bindings' into ffi/secp256r1

99f21ef


          Merge branch 'sdk-bindings' into ffi/secp256r1

765661a

thibault-martinez merged commit 626cce8 into sdk-bindings

7 checks passed

thibault-martinez deleted the ffi/secp256r1 branch

August 21, 2025 12:44

thibault-martinez mentioned this pull request

FFI for the Secp256r1PrivateKey, Secp256r1VerifyingKey and Secp256r1Verifier types #121

Closed

This was referenced Nov 5, 2025

release: iota-sdk-types v0.0.1-alpha.1 #377

Closed

release: iota-sdk-types v0.0.1-alpha.1 #378

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet