This repository has been archived by the owner on Mar 12, 2020. It is now read-only.
mobile/android: Use API level 19 to prevent a crash on some devices #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajivshah3
requested review from
th0br0,
thibault-martinez and
tsvisabo
as code owners
2 tasks
th0br0
suggested changes
Feb 25, 2019
| @@ -5,6 +5,10 @@ cc_library( | |||
| "jni.h", | |||
| ], | |||
| hdrs = ["Interface.h"], | |||
| defines = [ | |||
There was a problem hiding this comment.
Defines are broadcasted to dependencies, this should be copts.
There was a problem hiding this comment.
In general, these defines aren't necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue: iotaledger/trinity-wallet#1135
In optimized builds for
armeabi-v7a, thememcpyfunction is sometimes replaced with ARM's__aeabi_memcpy. Because of changes in later versions of the Android NDK, crashes can sometimes occur where this function is undefined. This is fixed by using API level 19 (see android/ndk#126 (comment)).Test Plan:
No longer crashes on Motorola Moto G4 (Android 6.0.1) and LG K3 (Android 6.0.1), which were previously affected by this issue