Move to AL2023 #5
Conversation
README.md
Outdated
| @@ -70,13 +70,23 @@ Additionally, to ensure the worker node joins an EKS cluster, the normal | |||
| EKS bootstrap script must be called. | |||
|
|
|||
| It's recommended to set this up in the User Data for the EC2 instance | |||
| to ensure it's run on first boot. An example user data for this is: | |||
| to ensure it's run on first boot. An example section fo this in a MIME | |||
There was a problem hiding this comment.
| to ensure it's run on first boot. An example section fo this in a MIME | |
| to ensure it's run on first boot. An example section of this in a MIME |
|
|
||
| # Add boot cmdline args | ||
| non_isolated_cores=$(/etc/xrd/get_non_isolated_cores.sh $ISOLATED_CORES) | ||
| grubby --update-kernel ALL --args "nohz_full=${ISOLATED_CORES} nohz=on skew_tick=1 intel_pstate=disable tsc=reliable nosoftlockup isolcpus=${ISOLATED_CORES} irqaffinity=${non_isolated_cores} hugepages=${boot_hugepages} rcu_nocbs=${ISOLATED_CORES} hugepagesz=1G default_hugepagesz=1G rcupdate.rcu_normal_after_boot=1" |
There was a problem hiding this comment.
How have you determined this is the set of required cmdline arguments? Are they following the ones which tuned generates? If so, I think it's worth having a comment here (and probably in README too) explaining that the tuned bootloader plugin does not work on EKS, but we match the cmdline args set by its realtime-virtual-guest profile (with the additional hugepage settings).
There was a problem hiding this comment.
This is the set added by TuneD realtime-virtual-guest with the additional arguments we previously passed to the bootloader plugin. Adding comment as suggested.
| @@ -0,0 +1,92 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
Does this have to be bash? I imagine it would be a lot simpler if it were in python
amazon-ebs.pkr.hcl
Outdated
| Kubernetes_Version = var.kubernetes_version | ||
| Base_AMI_ID = "{{ .SourceAMI }}" | ||
| Base_AMI_Name = "{{ .SourceAMIName }}" | ||
| Generated_By = "xrd-packer" |
Update xrd-packer to use AL2023 base image.
Changes:
grubbyinstead of TuneD bootloader pluginTesting: