Update QC Requirements #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated to the new release: v2.2.0
used ioos-qc=2.2.0 available on https://anaconda.org/conda-forge/ioos-qc
Upgrading to ioos-qc version 2.2.0 caused a TypeError: 'ABCMeta' object is not subscriptable when running glider_qc_tests.py. The issue traced back to the aggregate method from the ioos-qc package. To resolve this, I modified glider_qc.py to use the PandasStore method for creating the aggregated flags. Note: I have also added a TODO comments to set the extended file attribute as the current date-time.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Glider QC Updates
|
Ignoring test failure since |
Maybe this needed a rebase? Edit: Maybe we should not ignore test failures until we understand them. Looks like the code is broken on main. I'll try to investigate. |
|
@benjwadams looks like the latest ioos-qc should not be installable on Python 3.8, which is EOL BTW. I tried to update Python here but hit many old pinned dependencies and I don't know this app enough to make this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to use a stable version of ioos_qc on PyPI, makes several code changes to accommodate interface changes.