use requests before read_csv to get auth #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I tested this fix with this notebook: It worked: |
ocefpaf
reviewed
Dec 5, 2017
| @@ -1,5 +1,7 @@ | |||
| from __future__ import (absolute_import, division, print_function) | |||
|
|
|||
| import requests | |||
Member
There was a problem hiding this comment.
@rsignell-usgs if we leave this inside the function it would be to make it optional only when using get_var_by_attr.
In my next version requests will be mandatory , so instead of adding a try/except here I just moved it to the top already.
ocefpaf
approved these changes
Dec 5, 2017
Member
ocefpaf
left a comment
ocefpaf
left a comment
There was a problem hiding this comment.
Fixed a lint and moved requests to the top.
Once the CI finishes we can merge this one.
Member
|
We can fix the other lints in another PR and I'll add a test for this feature too. Thanks @rsignell-usgs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a workaround to access authenticated ERDDAP servers.
Since the pull requests for pandas to support authentication on
read_csvrequests (pandas-dev/pandas#17087) has not yet been merged, we can read the URL using requests and then pass to pandas using StringIO.