Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use mime types from webrtc/pion #669

Merged
merged 1 commit into from
Nov 15, 2022
Merged

refactor: use mime types from webrtc/pion #669

merged 1 commit into from
Nov 15, 2022

Conversation

ojroques
Copy link
Contributor

Description

ion-sfu redefines mime types already present in webrtc/pion. This leads to some issues as it appears the parsing of the SDP for codecs is not entirely case-insensitive.

Reference issue

Fix #661

Use mime types already present in webrtc/pion instead of redefining new
ones.

Fix #661
@ojroques ojroques changed the title fix: use mime types from webrtc/pion refactor: use mime types from webrtc/pion Oct 20, 2022
@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Base: 34.97% // Head: 35.68% // Increases project coverage by +0.70% 🎉

Coverage data is based on head (733bb5e) compared to base (7b6cc7b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #669      +/-   ##
==========================================
+ Coverage   34.97%   35.68%   +0.70%     
==========================================
  Files          24       24              
  Lines        2633     2637       +4     
==========================================
+ Hits          921      941      +20     
+ Misses       1570     1554      -16     
  Partials      142      142              
Impacted Files Coverage Δ
pkg/sfu/mediaengine.go 85.18% <100.00%> (+1.18%) ⬆️
pkg/sfu/router.go 43.25% <0.00%> (+2.24%) ⬆️
pkg/sfu/subscriber.go 56.41% <0.00%> (+7.69%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adwpc adwpc merged commit daf197a into ionorg:master Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

name of media engines are uppercase in pion/webrtc but are lowercase in pion/ion-sfu
2 participants