Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add health check server #589

Merged
merged 1 commit into from
Oct 26, 2021
Merged

feat: add health check server #589

merged 1 commit into from
Oct 26, 2021

Conversation

kevmo314
Copy link
Contributor

Description

This change adds a grpc health check service to the signalling server.

@kevmo314 kevmo314 requested a review from OrlandoCo September 22, 2021 21:12
@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #589 (c9d2992) into master (0e3628e) will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #589      +/-   ##
==========================================
- Coverage   36.20%   36.05%   -0.16%     
==========================================
  Files          25       25              
  Lines        2646     2646              
==========================================
- Hits          958      954       -4     
- Misses       1556     1559       +3     
- Partials      132      133       +1     
Impacted Files Coverage Δ
pkg/sfu/subscriber.go 57.69% <0.00%> (-1.29%) ⬇️
pkg/sfu/router.go 46.19% <0.00%> (-1.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e3628e...c9d2992. Read the comment docs.

Copy link
Contributor

@adwpc adwpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adwpc adwpc merged commit 09707c7 into master Oct 26, 2021
@adwpc adwpc deleted the feat/health branch October 26, 2021 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants