fix(sfu): revert rebaseTS #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RebaseTS will only allow to set offsets on first sync, causing issues on muting using API since TS and SN would be left in wrong state
Codecov Report
@@ Coverage Diff @@
## master #553 +/- ##
=======================================
Coverage 40.18% 40.19%
=======================================
Files 23 23
Lines 2431 2428 -3
=======================================
- Hits 977 976 -1
+ Misses 1326 1324 -2
Partials 128 128
Continue to review full report at Codecov.
|
billylindeman
approved these changes
Jul 15, 2021
davidzhao
approved these changes
Jul 15, 2021
dreamerns
pushed a commit
to dreamerns/ion-sfu
that referenced
this pull request
Sep 14, 2021
RebaseTS will only allow to set offsets on first sync, causing issues on muting using API since TS and SN would be left in wrong state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RebaseTS will only allow to set offsets on first sync, causing issues on muting using API since TS and SN would be left in wrong state