Fix microphone issues with Firefox and Safari #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Firefox can't open more than one microphone per process. When switching audio input device, we need to stop using current device before opening new one. This also somewhat affect safari, causing "A MediaStreamTrack ended due to a capture failure" error. * Remove overriding preffered codec profile with default.
|
LGTM, @cloudwebrtc FYI we removed the hardcoding of the codec profile BC this is an option that should be set by the API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox can't open more than one microphone per process. When switching audio input devices, we need to stop using the current device before opening a new one. This also somewhat affects safari, causing "A MediaStreamTrack ended due to a capture failure" error.
Remove overriding preferred codec profile with default.
Description
Reference issue
Fixes #...