check file paths for probed environment variables for existence #190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at 8704a72
The pull request updates the
dotnet-tools.json
file to use the latest tools and adds a new functioncheckExistence
to theUtils.fs
file to simplify file existence checks. These changes enhance the project's reliability and code quality.🤖 Generated by Copilot at 8704a72
⬆️🔧♻️
WHY
Fixes a validation gap described in ionide/FsAutoComplete#1014 (comment) - we check PATH and the 'default' locations for the existence of the actual
dotnet
binary, we should do the same for the paths inferred from environment variables. This makes users in mixed-mode scenarios less likely to experience errors.HOW
🤖 Generated by Copilot at 8704a72
.config/dotnet-tools.json
file to use the latest and stable releases (link, link)checkExistence
to thePaths
module in thesrc/Ionide.ProjInfo/Utils.fs
file to simplify the logic of checking file existence (link)Paths
module (<private>
,<private>
, andtryFindFile
) to use thecheckExistence
function instead of directly checking theExists
property of theFileInfo
object, to avoid code duplication and improve readability (link, link, link)