-
-
Notifications
You must be signed in to change notification settings - Fork 650
Review #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Sandipkakadiya
merged 79 commits into
ionicfirebaseapp:master
from
Sandipkakadiya:review
Mar 17, 2021
Merged
Review #220
Sandipkakadiya
merged 79 commits into
ionicfirebaseapp:master
from
Sandipkakadiya:review
Mar 17, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test cases added for button
master pull and test cases added for button and shimmer
gfavatar , gfimage test cases
gfcard test cases
gfborder test cases
test cases for buttons, icon buttons, social buttons, shimemr added
gfborder & gfalert test cases
Appbar testing done
gfbottomsheet test cases
Adding required fields to all widgets, which are missing in some components
Adding required fields to all widgets, which are missing
refactoring code to comply with null-safety
Merge nullsafety and testing code
1.2.4 release & analyze related changes, changelog updated
Test cases verification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Released with null safety along with test cases of majority of the components.