Skip to content

issues fixed #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deepikahr merged 1 commit into from
Jul 22, 2020
Merged

issues fixed #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions example/lib/main_temp.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1195,15 +1195,13 @@ class _MyHomePageState extends State<MyHomePage>
),

Checkbox(
value: check,
onChanged: null,
value: check,
onChanged: null,
// (val){
// print('on change val $val');
// }
),



GFCheckbox(
size: GFSize.SMALL,
activebgColor: GFColors.DANGER,
Expand Down Expand Up @@ -1432,7 +1430,6 @@ class _MyHomePageState extends State<MyHomePage>

//


//
// GFCarousel(
//// initialPage: 1,
Expand Down
18 changes: 10 additions & 8 deletions lib/components/checkbox/gf_checkbox.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,18 +83,20 @@ class _GFCheckboxState extends State<GFCheckbox> {

@override
Widget build(BuildContext context) => FocusableActionDetector(
enabled: enabled,
child: InkWell(
enabled: enabled,
child: InkWell(
onTap: onStatusChange,
child: Container(
height: widget.size,
width: widget.size,
decoration: BoxDecoration(
color: enabled ? isSelected
? widget.type == GFCheckboxType.custom
? Colors.white
: widget.activebgColor
: widget.inactivebgColor : Colors.grey,
color: enabled
? isSelected
? widget.type == GFCheckboxType.custom
? Colors.white
: widget.activebgColor
: widget.inactivebgColor
: Colors.grey,
borderRadius: widget.type == GFCheckboxType.basic
? BorderRadius.circular(3)
: widget.type == GFCheckboxType.circle
Expand Down Expand Up @@ -128,5 +130,5 @@ class _GFCheckboxState extends State<GFCheckbox> {
: widget.inactiveIcon,
),
),
);
);
}
2 changes: 1 addition & 1 deletion lib/components/list_tile/gf_list_tile.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ class GFListTile extends StatelessWidget {
subtitleText != null
? Text(
subtitleText,
style: TextStyle(
style: const TextStyle(
fontSize: 14.5,
color: Colors.black54,
),
Expand Down
2 changes: 1 addition & 1 deletion lib/components/search_bar/gf_search_bar.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ class MySingleChoiceSearchState<T> extends State<GFSearchBar<T>> {
color: Theme.of(context).primaryColor,
),
),
suffixIcon: Icon(Icons.search),
suffixIcon: const Icon(Icons.search),
border: InputBorder.none,
hintText: 'Search here...',
contentPadding: const EdgeInsets.only(
Expand Down
2 changes: 1 addition & 1 deletion lib/components/typography/gf_typography.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ class GFTypography extends StatelessWidget {
image: backgroundImage,
fit: BoxFit.cover,
colorFilter: backgroundImagecolorFilter ??
ColorFilter.mode(Colors.black54, BlendMode.darken),
const ColorFilter.mode(Colors.black54, BlendMode.darken),
)
: null,
),
Expand Down