feat(component): allow delegatesFocus on the component decorator

[MrAntix]

ref: #1008

[adamdbradley]

I like this, but wonder if we should instead have the options object passed in, rather than making a new option to the component decorator.

[manucorporat]

Agreed with Adam, i think it should be an object, probably allowing the shadow property to be both boolean or ShadowDomOptions:

 @Component({
     shadow: {
         delegateFocus: true
     }
  })

[adamdbradley]

@MrAntix would you be able to make the changes so shadow could either be a boolean, or an object? If it's an object we merge it with { mode: 'open' }. And if it's a boolean, the object should be { mode: 'open' }.

[MrAntix]

hows that look?

[adamdbradley]

Looking great. One thing is that in most cases, shadow: true will be the case, and the options would be used less often. So I think the net result of less could we be to not always build an options object, where every component would set {mode:'open'}, but rather have the run do the merge instead.

[manucorporat]

I added some comments, I think the runtime should provide the default value, let's not make the metadata bigger for the common case.

[MrAntix]

all done, do you need the commits squashed?

[manucorporat]

@MrAntix don't worry about it! we can squash them before merge

@adamdbradley, @jthoms1 the PR looks good to me!

[tehdb]

please merge and publish 🙏

[zoofadoofa]

This is not really an edge case, anything that is slotting in content into shareable components will need delegatesFocus
See Demo

[MrAntix]

Could this be released? I won't have capacity to upgrade to v1 as the breaking changes are too big and my project is going live with 0.18.x

[romulocintra]

Any news ;) any help needed ?

[driskull]

This would be nice to have

[adamdbradley]

Closing in favor of ad94fd2

[MrAntix]

Thanks