-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: hydrate crashes if component uses @Listen #5869
bug: hydrate crashes if component uses @Listen #5869
Comments
@mayerraphael thanks for raising this issue and helping us make Stencil better.
Can you please describe how you did trigger the event? If I change the |
Actually after some more testing, I am able to reproduce this issue and can investigate/work on a solution. |
A bug fix has been proposed in #5877 and a dev release ( |
Issue number: resolves #29681 --------- ### Release Notes <details> <summary>ionic-team/stencil (@​stencil/core)</summary> ### [`v4.19.2`](https://github.com/ionic-team/stencil/blob/HEAD/CHANGELOG.md#-4192-2024-07-02) [Compare Source](https://github.com/ionic-team/stencil/compare/v4.19.1...v4.19.2) ### Bug Fixes * **hydrate:** partially revert [#5838](ionic-team/stencil#5838) ([#5876](ionic-team/stencil#5876)) ([dfbc340](ionic-team/stencil@dfbc340)) * **hydrate:** support server side rendering of components with listener ([#5877](ionic-team/stencil#5877)) ([2c5b7f8](ionic-team/stencil@2c5b7f8)), fixes [#5869](ionic-team/stencil#5869) * **testing:** add testing sub module to export map ([#5873](ionic-team/stencil#5873)) ([bb2e04f](ionic-team/stencil@bb2e04f)), fixes [#5871](ionic-team/stencil#5871) and [#5868](ionic-team/stencil#5868) </details>
Prerequisites
Stencil Version
4.19.0
Current Behavior
If a component has a
@Listen()
function (tested with keydown) Stencil hydrate crashes and does not serialize the component.Culprit is the
hydrateComponent
method:Expected Behavior
For components to correctly serialize with
@Listen()
methods.System Info
No response
Steps to Reproduce
See repository.
Code Reproduction URL
https://github.com/mayerraphael/stencil-dsd-ssr-playground
Additional Information
The
my-whatever-component
has an@Listen()
method.Affects both
serializeShadowRoot
true and false.The text was updated successfully, but these errors were encountered: