Skip to content

Commit

Permalink
feat(environments): add process declaration (#420)
Browse files Browse the repository at this point in the history
* feat(environments): add process declaration

* remove @types packages after building starters

quick hack because they interfere with starters build

see https://www.typescriptlang.org/docs/handbook/tsconfig-json.html#types-typeroots-and-types

* update app-scripts to 3.2.0
  • Loading branch information
imhoffd authored Aug 24, 2018
1 parent 56f6ef1 commit 8cf0f06
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ jobs:
- save_cache: *save-cache-src
- run: npm run src:lint
- run: npm run src:build
- run: rm -rf node_modules/@types
- run: npm run starters:find-redundant
- run: npm run starters:build
- run: npm run starters:generate-checksum
Expand Down
2 changes: 1 addition & 1 deletion ionic-angular/base/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"zone.js": "0.8.26"
},
"devDependencies": {
"@ionic/app-scripts": "3.1.11",
"@ionic/app-scripts": "3.2.0",
"typescript": "~2.6.2"
}
}
1 change: 1 addition & 0 deletions ionic-angular/base/src/declarations.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
declare var process: { env: { [key: string]: string | undefined; } };

This comment has been minimized.

Copy link
@rdlabo

rdlabo Aug 28, 2018

Contributor

this declare causing ionic-team/ionic-cli#3541 .

I know this is feature function. ionic-team/ionic-cli#3300
but if delete this declare, local Ionic CLI worked.

This comment has been minimized.

Copy link
@imhoffd

imhoffd Aug 28, 2018

Author Contributor

Thanks for tracking that down @rdlabo -- I'll have to try this tomorrow. I'm not sure how @types/node is being installed.

cc @nphyatt

0 comments on commit 8cf0f06

Please sign in to comment.