Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(icon): icons now compile with TypeScript 4.4 #1014

Merged
merged 1 commit into from
Nov 8, 2021
Merged

fix(icon): icons now compile with TypeScript 4.4 #1014

merged 1 commit into from
Nov 8, 2021

Conversation

liamdebeasi
Copy link
Contributor

See #1011 (comment) for context.

This is a breaking change, but there is no change to usage as developers will use the ariaHidden and ariaLabel available on Element instead of the same props available on IonIcon.

@liamdebeasi liamdebeasi merged commit 1038a7f into master Nov 8, 2021
@liamdebeasi liamdebeasi deleted the ionicon-type branch November 8, 2021 21:26
@liamdebeasi liamdebeasi mentioned this pull request Nov 8, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@averyjohnston averyjohnston averyjohnston approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liamdebeasi @averyjohnston