Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update regex for Webpack ContextReplacementPlugin to work w/latest Ionic / Angular #34

Merged
merged 1 commit into from
May 13, 2017

Conversation

johnstonbl01
Copy link
Contributor

Using the latest version of Ionic, I was seeing:

WARNING in ./~/@angular/core/@angular/core.es5.js
5870:15-36 Critical dependency: the request of a dependency is an expression

WARNING in ./~/@angular/core/@angular/core.es5.js
5886:15-102 Critical dependency: the request of a dependency is an expression

WARNING in ./~/ionic-angular/util/ng-module-loader.js
54:11-36 Critical dependency: the request of a dependency is an expression

WARNING in ./~/ionic-angular/util/ng-module-loader.js
69:11-36 Critical dependency: the request of a dependency is an expression

The updated regular expression should resolve both of these issues. See similar issue here: ionic-team/ionic-framework#11072

@leifwells leifwells merged commit 0c1fe7a into ionic-team:master May 13, 2017
@jdnichollsc
Copy link

@johnstonbl01 What version of Ionic has this fix? thanks in advance!

WARNING in ./~/ionic-angular/util/ng-module-loader.js
54:11-36 Critical dependency: the request of a dependency is an expression

WARNING in ./~/ionic-angular/util/ng-module-loader.js
69:11-36 Critical dependency: the request of a dependency is an expression

@jdnichollsc
Copy link

@johnstonbl01 any help with this issue is really appreciated! 🙏 ionic-team/ionic-framework#11072
Thanks in advance, Nicholls

@johnstonbl01
Copy link
Contributor Author

@jdnichollsc I honestly don't remember what version this was happening with. 😞 It was whatever the most recent version was back in April of this year -- 3ish, I think? I no longer have that code on this machine to confirm though -- sorry.

@jdnichollsc
Copy link

Yeah, this keeps happening with the latest version :/

@jdnichollsc
Copy link

@johnstonbl01 but what do you think with the following PR? ionic-team/ionic-app-scripts#1360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants