This repository has been archived by the owner on Nov 4, 2021. It is now read-only.
update watch ''app/pages/**/*.scss" #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ionic2 beta.4's gulpfile is watch 'app/**/*.scss'. so when ''app/pages/**/*.scss" is changed, browser live reloaded. But now, don't make css file. Angular2 have function css capsuled and Ionic2 can use this. example. > @page({ > styleUrls : ['build/css/index/index.css'], > }) so I think ionic-gulp-sass-build must watch ''app/pages/**/*.scss'. thanks.
|
Hey thanks for the PR. Right now Ionic's Sass isn't really set up to take advantage of style encapsulation, so I'm not sure this makes sense to do right now, but will definitely be a possibility in the future. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ionic2 beta.4's gulpfile is watch 'app//*.scss'. so when ''app/pages//*.scss" is changed, browser live reloaded.
But now, don't make css file.
Angular2 have function css capsuled and Ionic2 can use this.
example.
so I think ionic-gulp-sass-build must watch ''app/pages/*/.scss'.
thanks.