-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency: angular-ui-router to 0.2.10 #941
Conversation
@oori I would be interested to know if you use nested states/views (like 3 or 4 levels deep). I am experiences some issues where calling $state.go('^') was returning to the previous state. Althought, the content was correct, the header title did not get updated. I am using a "side menu" style setup on ionic 0.9.27 currently. Do you happen to have any samples I could look at ? Thanks! |
When we previously upgraded ui-router we came across a few new bugs, basically with transcluded content. We'll have to setup more tests then we'll include it. |
@adamdbradley Sure. I know ui-router got it's "fame" on 0.2.7, but lately some hard-core bugs are being actively fixed. I recommend.. @keithdmoore At the moment I mainly use ui-router for two things: |
@oori Thanks for the offer. I managed to figure out my problem. It was between my keyboard and chair. I ended up removing my nested views and opted to share the data thru services. I also needed to use the "@" to find the proper view to place the template in. Like "menuContent@menu", for example. Got the ionic back button and my own "back/cancel" buttons (that use stage to go back) all working. I plan on upgrading the ui-router to 0.2.10 soon. I will post back here with my findings. |
+1 for the upgrade: After doing some testing with ui-router 0.2.10, I see that the ui-sref-opts="{ reload: true }" is being honored now. Not seeing any issues. |
Hi @oori, thanks. We're pushing out a minor fixes release in the next couple days, then we'll merge this and test it out over the next week. |
When I tested angular-ui-router 0.2.10 previously, I referenced the ionic and angular libraries individually. I was wondering how to build the ionic-bundle.js with this new dependency. After modifying the bower.json file with the new version of angular-ui-router, I did a bower install and then a gulp build --release. The dist folder did not have the updated router version. Please help, I am new to building js projects. |
Clean (purge) bower cache first. Otherwise, bower doesnt really read your changes.. |
The build system reads it from config/js/lib/angular-ui-router/ On Wed, Apr 16, 2014 at 2:25 PM, Oori [email protected] wrote:
|
Thanks guys. Moved the updated angular-ui-router files from bower_components to the config/js/lib/angular-ui-router and was able to get the new version in ionic-bundle.js. |
I don't think this is going to happen. To be honest, we are looking into building a new nav system from scratch which will enable us to do a lot more stuff we want to do. Closing for now. |
@ajoslin & @mlynch that's a shame.. this update resolves real-world issues, and we haven't run into any new ionic issues because of this. (have you run into any issues we should know of before going to production?) sure, we can do this update manually (as we do), but until you move to a new routing module, your users will continue to hit 0.2.7 issues (for example: http://forum.ionicframework.com/t/errors-during-minifying/2330) thanks. |
That is unfortunate. I have been using 0.2.10 for about a month now too. Have not run into any issues. It fixed a problem with the ui-sref-opts being applied. So I need it. I guess I will just keep using a custom build. |
Sorry I was under the impression the new version broke it. I'll reopen this Sent from my iPhone
|
@mlynch said: "I'll reopen this" cheers. |
So what's the actual plan, friends? |
We will most likely update the ui-router if there aren't outstanding issues, but we are actively looking into implementing our own that is more friendly for hybrid mobile. |
@somethingnew2-0 Can you share more about what's making you consider the option to opt out of ui-router? It's an amazing project for what I know, and I'd really like to know which aspects of it aren't hybrid mobile friendly enough. |
@mlynch or @adamdbradley? |
We'll upgrade right after we release beta.4 tomorrow.
|
Hm, I take it ui-router still has a place in Ionic then. I'm glad so far. |
ui-router has a place in Ionic for now. We are evaluating options for the future. |
done. 0.2.10 is up on the nightly builds. |
ui-router 0.2.7 is outdated and contains basic bugs such as angular-ui/ui-router#692 preventing the use of "ui-sref-active" on distributed version. UI-view animations fix and much more..
I use ionic and enhance it a lot with ui-router directly (I dislike static href, and love ui-sref... in addition to using my own ui-views, etc..)
I've tested this on my setup with 0.2.10 and it is flawless.
Anything preventing us from moving forward to 0.2.10 ?