Skip to content

Conversation

@OS-jacobbell
Copy link
Contributor

For Stencil Nightly alert messages, instead of checking if anything succeeded, check if nothing failed.


What is the current behavior?

Both a success and failure message was sent when some jobs passed and some failed.

What is the new behavior?

  • Success message should only be sent if nothing failed.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Instead of checking if anything succeeded, check if nothing failed.
@OS-jacobbell OS-jacobbell requested a review from a team as a code owner November 19, 2025 15:00
@vercel
Copy link

vercel bot commented Nov 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
ionic-framework Ready Ready Preview Comment Nov 19, 2025 3:00pm

@OS-jacobbell OS-jacobbell added this pull request to the merge queue Nov 19, 2025
Merged via the queue into main with commit eeb15c3 Nov 19, 2025
98 checks passed
@OS-jacobbell OS-jacobbell deleted the fix-stencil-nightly-messages branch November 19, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants