Fix for Loading getting stuck #3021
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for Loading getting stuck if the $stateChangeSuccess is fired during the delay.
Fix for Loading getting stuck if the $stateChangeSuccess is fired during the delay. It's not even needed to call `$rootScope.$on` in the delay callback. `hideLoader` does everything that's needed, including the delay timer cancel.
Fixed one more wrong move(rename) operation!
Fix for `nextViewOptions` being expired too early due to state's `resolve` loadings.
Getting used to the system... reverted the changes to make a separate branch later.
|
I committed this same fix a couple weeks ago without seeing your PR. Thanks though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for Loading getting stuck if the $stateChangeSuccess is fired during the delay. It's not even needed to call
$rootScope.$onin the delay callback.hideLoaderdoes everything that's needed, including the delay timer cancel.