-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(checkbox): display as block when justify or alignment properties are defined #29783
Merged
Merged
Changes from 9 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
720ef8a
feat(checkbox): display as flex when justify property is defined
brandyscarney 9887cf8
style: explicit class names
brandyscarney 7365fb3
fix(checkbox): use flex display and apply width 100% to checkbox wrapper
brandyscarney 55a4843
Revert "fix(checkbox): use flex display and apply width 100% to check…
brandyscarney dcb8a4a
fix(checkbox): only apply justify property in item
brandyscarney a669fc2
fix(checkbox): set justify content in the css instead
brandyscarney 86bf565
fix(checkbox): 100% width wrapper for long labels
brandyscarney 4097c38
chore(): add updated snapshots
Ionitron 75aa917
test(checkbox): remove justify property from a11y test
brandyscarney dd7f779
test(checkbox): remove explicit width from label tests
brandyscarney 50b49a3
chore(): add updated snapshots
brandyscarney 3742d54
test(checkbox): add tests for truncating and full width checkbox
brandyscarney c620298
chore(): add updated snapshots
brandyscarney 4bce2f3
test(checkbox): add full-width example, remove display block
brandyscarney bcba3d5
fix(checkbox): display flex when align is set
brandyscarney cf38d15
chore(): add updated snapshots
brandyscarney fc3f1db
fix(checkbox): change display to block & document it
brandyscarney d284b02
fix(checkbox): remove width 100%
brandyscarney 6c9738e
chore(): add updated snapshots
brandyscarney 6647ed2
style: lint
brandyscarney a8120f3
Merge branch 'feature-8.3' into ROU-10906
brandyscarney 94b4fc6
Merge branch 'feature-8.3' into ROU-10906
brandyscarney File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,7 +36,7 @@ configs({ directions: ['ltr'] }).forEach(({ title, config, screenshot }) => { | |
font-size: 310%; | ||
} | ||
</style> | ||
<ion-checkbox justify="start" checked>Checked</ion-checkbox> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
<ion-checkbox checked>Checked</ion-checkbox> | ||
`, | ||
config | ||
); | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is required so that the user can still do the following, with a space between the label and checkbox: