Skip to content

chore(vue): bump vue dev-deps to have generic type #29718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 16, 2024
Merged

chore(vue): bump vue dev-deps to have generic type #29718

merged 3 commits into from
Jul 16, 2024

Conversation

sean-perkins
Copy link
Contributor

@sean-perkins sean-perkins commented Jul 16, 2024

Issue number: Internal


What is the current behavior?

In v3.2.46 vue was updated to add support for a generic type argument to the Plugin type. In #29637 Ionic's Vue plugin was updated to use the generic, but the@ionic/vue project is currently installing v3.2.37.

This results in a local type checking error and build error:

(!) Plugin typescript: @rollup/plugin-typescript TS2315: Type 'Plugin_2' is not generic.
src/ionic-vue.ts: (24:24)

24 export const IonicVue: Plugin<[IonicConfig?]> = {

What is the new behavior?

  • Bumps and pins the dev dependency of vue to 3.2.46. There are other breaking changes that Vue has shipped in minor/patch cycles that prevents from updating to the latest.
  • Resolves the type checking error locally during build of the@ionic/vue package

Does this introduce a breaking change?

  • Yes
  • No

Other information

Validation steps:

  1. Checkout the branch
  2. Build core/
  3. In packages/vue, install latest pinned dependencies with npm ci
  4. Sync the changes to the vue package with npm run sync
  5. Open /packages/vue/src/ionic-vue.ts
  6. Observe: No type errors on L24
  7. Run npm run build
  8. Observe: No build errors

@sean-perkins sean-perkins requested a review from thetaPC July 16, 2024 19:01
@sean-perkins sean-perkins requested a review from a team as a code owner July 16, 2024 19:01
Copy link

vercel bot commented Jul 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 7:59pm

@github-actions github-actions bot added the package: vue @ionic/vue package label Jul 16, 2024
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thetaPC thetaPC added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit 2bc3b1f Jul 16, 2024
49 checks passed
@thetaPC thetaPC deleted the sp/vue-types branch July 16, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants