Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input, textarea, select): account for multiple start/end slot elements #29172

Merged
merged 6 commits into from
Mar 19, 2024

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Mar 18, 2024

Issue number: Internal


What is the current behavior?

We add margin on content in the start/end slots so they do not run up against either the visible text label of the text in the input. However, we did not account for when multiple elements are placed into the same slot. As a result, this margin is added more times than it needs to be.

What is the new behavior?

  • Updated the selector so the margin is only applied to either the last or first element in the slot.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Test Steps:

  1. Check out feature-8.0
  2. Add multiple ion-button elements into either the start or end slot on an input (you can reuse the template in src/components/input/test/slots
  3. Observe that margin is added to every ion-button.

@github-actions github-actions bot added the package: core @ionic/core package label Mar 18, 2024
@liamdebeasi liamdebeasi changed the title fix(input, textarea, select): account for multiple start/end slot ele… fix(input, textarea, select): account for multiple start/end slot elments Mar 18, 2024
@liamdebeasi liamdebeasi changed the title fix(input, textarea, select): account for multiple start/end slot elments fix(input, textarea, select): account for multiple start/end slot elements Mar 18, 2024
@liamdebeasi liamdebeasi marked this pull request as ready for review March 18, 2024 20:51
@liamdebeasi liamdebeasi requested a review from a team as a code owner March 18, 2024 20:51
@liamdebeasi liamdebeasi requested review from sean-perkins and a team and removed request for a team March 18, 2024 20:51
Copy link
Contributor

@sean-perkins sean-perkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good with slotting multiple things to start/end slots 👍

@liamdebeasi liamdebeasi merged commit acc1042 into feature-8.0 Mar 19, 2024
42 checks passed
@liamdebeasi liamdebeasi deleted the ld/input-slot-margin branch March 19, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants