Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(input-shims): disable input blurring util by default #29104

Merged
merged 6 commits into from
Mar 1, 2024
Merged
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion core/src/utils/input-shims/input-shims.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,15 @@ export const startInputShims = async (config: Config, platform: 'ios' | 'android
const keyboardHeight = config.getNumber('keyboardHeight', 290);
const scrollAssist = config.getBoolean('scrollAssist', true);
const hideCaret = config.getBoolean('hideCaretOnScroll', isIOS);
const inputBlurring = config.getBoolean('inputBlurring', isIOS);

/**
* The team is evaluating if inputBlurring is still needed. As a result
* this feature is disabled by default as of Ionic 8.0. Developers are
* able to re-enabled it temporarily. The team may remove this utility
liamdebeasi marked this conversation as resolved.
Show resolved Hide resolved
* if it is determined that doing so would not bring any adverse side effects.
* TODO FW-6014 remove input blurring utility (including implementation)
*/
const inputBlurring = config.getBoolean('inputBlurring', false);
const scrollPadding = config.getBoolean('scrollPadding', true);
const inputs = Array.from(doc.querySelectorAll('ion-input, ion-textarea')) as HTMLElement[];

Expand Down Expand Up @@ -113,6 +121,7 @@ export const startInputShims = async (config: Config, platform: 'ios' | 'android
}
};

console.log(inputBlurring, INPUT_BLURRING);
liamdebeasi marked this conversation as resolved.
Show resolved Hide resolved
if (inputBlurring && INPUT_BLURRING) {
enableInputBlurring();
}
Expand Down
Loading