feat(input): remove size property in favor of CSS styling #28903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
package: core
sean-perkins
requested review from
liamdebeasi,
thetaPC and
a team
as code owners
liamdebeasi
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: Internal
What is the current behavior?
The
ion-inputcomponent currently specifies asizeattribute to align with the HTMLinputimplementation. However, Ionic's custom appearance for MD and iOS is not compatible and should not be used with thesizeattribute: #27945 (comment).What is the new behavior?
sizeproperty has been removed fromion-input.Does this introduce a breaking change?
The
sizeattribute has been removed fromion-input. As it was not compatible before, this is likely to have a minimal impact to developers. If your application is using thesizeattribute, replace the usage with CSS styling to control the width of theion-input.Other information