fix(select): use correct aria-haspopup value #28265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thetaPC
requested review from
a team and
liamdebeasi
and removed request for
a team
liamdebeasi
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
I tested the changes on TalkBack + Android, VoiceOver + iOS, VoiceOver + Safari for macOS, NVDA + Chrome, and NVDA + Firefox. They all work well! Can we hold off on merging this until ionic-team/ionic-docs#3156 is merged? Would be good to have these changes ship together.
|
@liamdebeasi I'll switch the base branch to |
github-actions
bot
added
package: angular
github-actions
bot
removed
package: angular
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
ion-selectuses thearia-haspopup="listbox"even though the popup is a dialog.What is the new behavior?
ion-selecttriggers a dialog, the value foraria-haspopupnow reflects thatDoes this introduce a breaking change?
Other information
N/A