Skip to content

Conversation

@liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Jun 12, 2023

Issue number: N/A


What is the current behavior?

Slotted content added async does not cause the component to re-render.

What is the new behavior?

  • Adding slotted content async causes the component to re-render
  • Changes within the slotted content will also cause the component to re-render so the notch is updated

Does this introduce a breaking change?

  • Yes
  • No

Other information

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the package: core @ionic/core package label Jun 12, 2023
@liamdebeasi liamdebeasi changed the title 4135 dynamic feat(input): add workaround for dynamic slot content Jun 12, 2023
Base automatically changed from 4135-base to FW-4135 June 12, 2023 19:00
@liamdebeasi liamdebeasi requested review from a team, averyjohnston, brandyscarney and mapsandapps and removed request for a team and mapsandapps June 13, 2023 15:15
@liamdebeasi
Copy link
Contributor Author

Going to keep the same reviewers since they reviewed the previous PRs for this feature

@liamdebeasi liamdebeasi marked this pull request as ready for review June 13, 2023 15:29
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@liamdebeasi liamdebeasi merged commit eb95367 into FW-4135 Jun 14, 2023
@liamdebeasi liamdebeasi deleted the 4135-dynamic branch June 14, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants