Skip to content

feat(input): add label slot #27633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
liamdebeasi merged 6 commits into from
Jun 12, 2023
Merged

feat(input): add label slot #27633

liamdebeasi merged 6 commits into from
Jun 12, 2023

Conversation

@liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Jun 12, 2023 •
edited
Loading

Issue number: N/A

What is the current behavior?

Input only accepts plaintext labels.

What is the new behavior?

  • Input can now accept custom HTML labels via a slot

A few implementation notes:

  • Support for dynamically adding/removing slotted content will be added in a separate PR.
  • Support for the notch outline will be added in a separate PR.
  • The existing start/end placement label overflow tests were made redundant with the new tests I added. As a result, I removed the old tests.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@bolt-new-by-stackblitz
Copy link

bolt-new-by-stackblitz bot commented Jun 12, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the package: core @ionic/core package label Jun 12, 2023
@liamdebeasi liamdebeasi changed the title 4135 base feat(input): add label slot Jun 12, 2023
@liamdebeasi liamdebeasi marked this pull request as ready for review June 12, 2023 14:32
@liamdebeasi liamdebeasi requested review from a team, averyjohnston and brandyscarney and removed request for a team and brandyscarney June 12, 2023 14:40
brandyscarney
brandyscarney requested changes Jun 12, 2023
View reviewed changes
@liamdebeasi liamdebeasi requested review from brandyscarney and removed request for averyjohnston June 12, 2023 16:22
@liamdebeasi liamdebeasi merged commit 1188234 into FW-4135 Jun 12, 2023
@liamdebeasi liamdebeasi deleted the 4135-base branch June 12, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandyscarney brandyscarney brandyscarney approved these changes

+1 more reviewer

@sean-perkins sean-perkins sean-perkins approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

package: core @ionic/core package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@liamdebeasi @brandyscarney @sean-perkins @Ionitron