-
Notifications
You must be signed in to change notification settings - Fork 13.4k
fix(spinner): allow resizing of dots, bubbles, and circles #27424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
a18b9ed
fix(spinner): allow resizing of dots, bubbles, and circles
mapsandapps 29c42d4
chore(): add updated snapshots
Ionitron e7605db
Improve visual tests
mapsandapps 489c8b0
chore(): add updated snapshots
Ionitron cd1dff0
Merge branch 'main' into FW-3692
mapsandapps 4e19a24
Merge branch 'FW-3692' of github.com:ionic-team/ionic-framework into …
mapsandapps d5c45cc
Remove deleted snapshots
mapsandapps a8dda77
Take a smaller screenshot
mapsandapps e6a531c
Take a smaller screenshot
mapsandapps cf7a489
chore(): add updated snapshots
Ionitron 2141ed6
Take a smaller screenshot
mapsandapps d6959ec
Merge branch 'FW-3692' of github.com:ionic-team/ionic-framework into …
mapsandapps 86993ea
chore(): add updated snapshots
Ionitron 596cf69
Merge branch 'main' into FW-3692
mapsandapps File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file removed
BIN
-32.5 KB
...lor/spinner.e2e.ts-snapshots/spinner-color-diff-ios-ltr-Mobile-Chrome-linux.png
Binary file not shown.
Binary file removed
BIN
-34.8 KB
...or/spinner.e2e.ts-snapshots/spinner-color-diff-ios-ltr-Mobile-Firefox-linux.png
Binary file not shown.
Binary file removed
BIN
-29 KB
...lor/spinner.e2e.ts-snapshots/spinner-color-diff-ios-ltr-Mobile-Safari-linux.png
Binary file not shown.
Binary file modified
BIN
-3.16 KB
(90%)
...olor/spinner.e2e.ts-snapshots/spinner-color-diff-md-ltr-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-3.17 KB
(91%)
...lor/spinner.e2e.ts-snapshots/spinner-color-diff-md-ltr-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-2.77 KB
(90%)
...olor/spinner.e2e.ts-snapshots/spinner-color-diff-md-ltr-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,33 @@ | ||||||
| import { expect } from '@playwright/test'; | ||||||
| import { configs, test } from '@utils/test/playwright'; | ||||||
|
|
||||||
| /** | ||||||
| * The resize behavior does not vary across directions or modes. | ||||||
| */ | ||||||
| configs({ directions: ['ltr'], modes: ['md'] }).forEach(({ title, screenshot, config }) => { | ||||||
| test.describe(title('spinner: resize'), () => { | ||||||
| test.beforeEach(async ({ page }) => { | ||||||
| await page.setViewportSize({ width: 320, height: 340 }); | ||||||
| }); | ||||||
| test('should not have visual regressions', async ({ page }) => { | ||||||
| await page.setContent( | ||||||
| ` | ||||||
| <ion-content id="content"> | ||||||
| <ion-spinner name="lines"></ion-spinner> | ||||||
| <ion-spinner name="lines-small"></ion-spinner> | ||||||
| <ion-spinner name="lines-sharp"></ion-spinner> | ||||||
| <ion-spinner name="lines-sharp-small"></ion-spinner> | ||||||
| <ion-spinner name="circular"></ion-spinner> | ||||||
| <ion-spinner name="dots"></ion-spinner> | ||||||
| <ion-spinner name="bubbles"></ion-spinner> | ||||||
| <ion-spinner name="circles"></ion-spinner> | ||||||
| <ion-spinner name="crescent"></ion-spinner> | ||||||
| </ion-content> | ||||||
mapsandapps marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||||||
| `, | ||||||
| config | ||||||
| ); | ||||||
|
|
||||||
| await expect(page.locator('#content')).toHaveScreenshot(screenshot(`spinner-resize-diff`)); | ||||||
|
||||||
| await expect(page.locator('#content')).toHaveScreenshot(screenshot(`spinner-resize-diff`)); | |
| await expect(page).toHaveScreenshot(screenshot(`spinner-resize-diff`)); |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the tips!
Binary file added
BIN
+3.67 KB
...ize/spinner.e2e.ts-snapshots/spinner-resize-diff-md-ltr-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+5.73 KB
...ze/spinner.e2e.ts-snapshots/spinner-resize-diff-md-ltr-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+4.19 KB
...ize/spinner.e2e.ts-snapshots/spinner-resize-diff-md-ltr-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.