Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(input): deprecate accept property #25501

Merged
merged 2 commits into from
Jun 21, 2022
Merged

refactor(input): deprecate accept property #25501

merged 2 commits into from
Jun 21, 2022

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Jun 17, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #25500

The type property has never accepted 'file' as a valid value. However, our documentation makes references to 'file' in the multiple and accept properties.

Both descriptions were likely adapted from descriptions on MDN, which made reference to 'file'.

Additionally, the accept property was added to have greater parity with the native input: fe99d19 However, this was a mistake as ion-input never supported 'file'.

What is the new behavior?

  • Deprecated the accept property
  • Revised the accept property to state that it is ignored. It technically works if you force type to 'file', but 'file' is not a valid value. We could stop passing accept into the native input, but that would be a breaking change.
  • Removed the 'file' reference from the multiple prop description.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@liamdebeasi liamdebeasi changed the title refactor(): deprecate accept property refactor(input): deprecate accept property Jun 17, 2022
@github-actions github-actions bot added the package: core @ionic/core package label Jun 17, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review June 17, 2022 16:55
@liamdebeasi liamdebeasi requested a review from a team as a code owner June 17, 2022 16:55
@liamdebeasi liamdebeasi requested review from averyjohnston and sean-perkins and removed request for a team June 17, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(react): IonInput doesn't allow to use type="file"
3 participants