Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): add param types to useIonPopover dismiss function #25311

Merged
merged 1 commit into from
May 18, 2022

Conversation

averyjohnston
Copy link
Contributor

@averyjohnston averyjohnston commented May 18, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The type of the dismiss function returned by useIonPopover does not account for the data and role parameters added here: #25209 Note that this change was already made to useIonModal, but was missed for popovers.

Issue URL: N/A

What is the new behavior?

Parameters added to function type.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev build: 6.1.7-dev.11652895286.14d01bc9

@averyjohnston averyjohnston requested a review from a team as a code owner May 18, 2022 17:42
@github-actions github-actions bot added the package: react @ionic/react package label May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: react @ionic/react package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants