fix(scroll-assist): touch end events continue to bubble on inputs #25282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: resolves #25229
There are two issues here:
ion-input
, thetouchend
event never fires.Both of these issues are happening because of the follow code: https://github.com/ionic-team/ionic-framework/blob/main/core/src/utils/input-shims/hacks/scroll-assist.ts#L30
stopPropagation
prevents an event from bubbling. So when we callstopPropagation
, thetouchend
event does not bubble up and the swipe gesture never completes. The gesture util listens fortouchend
to know when to fire theonEnd
callback: https://github.com/ionic-team/ionic-framework/blob/main/core/src/utils/gesture/pointer-events.ts#L43What is the new behavior?
stopPropagation
code to allow thetouchend
event to continue to bubble. This fixes both issues.I fixed a similar issue in 2021 where the
click
event was being suppressed in the same area: f7d4c21Does this introduce a breaking change?
Other information