Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): reset breakpoint to initial breakpoint on present #25246

Merged
merged 7 commits into from
May 16, 2022

Conversation

sean-perkins
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

When an inline sheet modal is dismissed, the breakpoint isn't set back to the initial breakpoint. When the sheet modal is presented again, the visual state will not match the internal state.

Issue URL: #25245

What is the new behavior?

  • The internal currentBreakpoint state is set to the initialBreakpoint on dismiss.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@sean-perkins sean-perkins requested a review from a team as a code owner May 5, 2022 17:05
@github-actions github-actions bot added the package: core @ionic/core package label May 5, 2022
@sean-perkins sean-perkins changed the title fix(modal): reset breakpoint to initial breakpoint on dismiss fix(modal): reset breakpoint to initial breakpoint on present May 16, 2022
@sean-perkins sean-perkins merged commit 2557bf3 into main May 16, 2022
@sean-perkins sean-perkins deleted the FW-1461 branch May 16, 2022 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants